Weaknesses: Electric (x2), Grass (x2)
Resistances: Fire (x1/2), Water (x1/2), Ice (x1/2), Steel (x1/2)
Immunities: Water (with Water Absorb)

Strategy:

With Vaporeon's excellent HP, it can make long-lasting Substitutes. After creating a Substitute, it can then Baton Pass it to a teammate such as Metagross, Salamence, or any other sweeper who normally dooesn't use Substitute. It can also pass Defense boosts by using Acid Armor.

Wish helps Vaporeon heal itself and other Pokémon on the team. As you can see, Vaporeon can be a great team player with this moveset and is an excellent Pokémon to use in Baton Pass teams.

Try to get its Defense as high as possible, especially if you don't have Acid Armor. Vaporeon is good against physical sweepers like Aerodactyl and Rhyperior, but first it needs a good Defense to take on their physical attacks. Vaporeon's actual Defense stat is low compared to certain other Water types (including Milotic and Swampert), so boost it using EVs and a Bold Nature.


Wish

The previous moveset will have trouble with enemy Water-types, including other Vaporeons. This second set can handle Water opponents by using Toxic to weaken them. As long as they don't have Rest, they'll find it hard to survive long with the constant poison damage. Hidden Power Electric is another option to take care of Water-types and is mainly used to defeat Gyarados, who is a major pain for Vaporeon. Again Wish is there to provide a method of healing for both Vaporeon and the rest of the team.

Protect is there for two reasons: stall the opponent as they take poison damage and ensure that Wish will heal you, since Wish takes two turns to work and you may not always survive the next turn.

However, if you find that Grass and Dragon opponents are giving you trouble, then use Ice Beam instead to take care of those types.

How to counter Vaporeon:

If Vaporeon doesn't have Hidden Power Electric, then just about every Water type counters it. Notable ones include Milotic, whose Marvel Scale lets it benefit from Toxic, and Gyarados, who can shut Vaporeon down with Taunt. Lanturn, Lapras, and Starmie also do a great job since they can learn Thunderbolt.

If Vaporeon doesn't have Ice Beam, then Grass types easily do the trick. Venusaur, Breloom, Roserade, Celebi, and Shaymin are the best choices since they are either immune to Toxic or can easily heal themselves using Natural Cure.

Ludicolo handles Vaporeon no matter if it has Ice Beam or HP Electric, since it's not weak against either move. It can defeat it with Energy Ball or use Leech Seed to sap its high HP.

Blissey and Cresselia are obvious answers given their massive HP and Special Defense.

As far as Electric types go, most of them have trouble switching in on Vaporeon's Surf. Raikou is an exception since it has high Special Defense and Calm Mind. Zapdos also fares well if it has Roost.

Gardevoir with Trace is a pretty special counter since Trace copies Vaporeon's Water Absorb, making her immune to Surf. Her high Special Defense protects her from Vaporeon's other attacks while she blasts it with Thunderbolt.

Links to Pokedex Entries

Bulbapedia
LegendaryPokemon
Psypoke
Serebii
Smogon
Veekun